New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Config Schema): Add enhanced object syntax for plugins #8259
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8259 +/- ##
=======================================
Coverage 88.09% 88.09%
=======================================
Files 248 248
Lines 9377 9377
=======================================
Hits 8261 8261
Misses 1116 1116
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jimjenkins5 ! That looks very good. I've proposed few improvements, so schema is complete
properties: { | ||
localPath: { type: 'string' }, | ||
modules: { type: 'array', items: { type: 'string' } }, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make modules
required, also let's add additionalProperties: false
, so eventual typos are picked and not ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made these 2 changes. Thanks!
9a5a829
to
9fa75b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jimjenkins5 !
Closes: #8206